Skip to content

fix: fix duplicative log payloads on unload #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix: fix duplicative log payloads on unload #1166

merged 4 commits into from
Aug 29, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Aug 28, 2024

Ensure agent clears buffer on page navigation unload harvests to prevent duplicative payloads from being sent.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-307620

Testing

Copy link

github-actions bot commented Aug 28, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.66 kB / 11.35 kB (gzip) 32.66 kB / 11.35 kB (gzip) 0% / 0% (gzip)
lite async-chunk 50.83 kB / 16.35 kB (gzip) 50.83 kB / 16.35 kB (gzip) 0% / 0% (gzip)
pro loader 53.86 kB / 18.05 kB (gzip) 53.84 kB / 18.05 kB (gzip) -0.03% / -0.02% (gzip)
pro async-chunk 99.3 kB / 29.69 kB (gzip) 100.06 kB / 29.83 kB (gzip) 0.76% / 0.46% (gzip)
spa loader 61.79 kB / 20.5 kB (gzip) 61.78 kB / 20.5 kB (gzip) -0.02% / 0% (gzip)
spa async-chunk 114.44 kB / 34.03 kB (gzip) 115.2 kB / 34.17 kB (gzip) 0.66% / 0.42% (gzip)

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (2e29a6e) to head (ca325b2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/features/logging/aggregate/index.js 90.00% 1 Missing and 1 partial ⚠️
src/features/utils/event-buffer.js 96.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   88.77%   88.77%   -0.01%     
==========================================
  Files         161      163       +2     
  Lines        7348     7410      +62     
  Branches     1453     1471      +18     
==========================================
+ Hits         6523     6578      +55     
- Misses        707      714       +7     
  Partials      118      118              
Flag Coverage Δ
integration-tests 91.92% <100.00%> (+0.08%) ⬆️
unit-tests 78.82% <90.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 29, 2024

Static Badge

Last ran on August 29, 2024 12:44:51 CDT
Checking merge of (ca325b2) into main (2e29a6e)

@metal-messiah metal-messiah merged commit 52bb088 into main Aug 29, 2024
33 of 35 checks passed
@metal-messiah metal-messiah deleted the logs-bug branch August 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants