Skip to content

feat: Configure Session Replay to wait for DOMContentLoaded #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

metal-messiah
Copy link
Member

Decrease the time spent waiting by triggering Session Replay mutation observer wrapping on the DOMContentLoaded event instead of the previously used window load event. This ensures wrapping is completed before the load chain.

Overview

Related Issue(s)

NR-300929

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.58 kB / 11.35 kB (gzip) 32.58 kB / 11.35 kB (gzip) 0% / 0% (gzip)
lite async-chunk 50.46 kB / 16.25 kB (gzip) 50.46 kB / 16.25 kB (gzip) 0% / 0% (gzip)
pro loader 53.64 kB / 18.08 kB (gzip) 53.64 kB / 18.08 kB (gzip) 0% / 0% (gzip)
pro async-chunk 98.79 kB / 29.49 kB (gzip) 98.79 kB / 29.49 kB (gzip) 0% / 0% (gzip)
spa loader 61.6 kB / 20.51 kB (gzip) 61.6 kB / 20.51 kB (gzip) 0% / 0% (gzip)
spa async-chunk 113.88 kB / 33.82 kB (gzip) 113.88 kB / 33.82 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (4292f00) to head (210ee3e).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   87.83%   88.75%   +0.92%     
==========================================
  Files         162      165       +3     
  Lines        7291     7374      +83     
  Branches     1435     1636     +201     
==========================================
+ Hits         6404     6545     +141     
+ Misses        770      720      -50     
+ Partials      117      109       -8     
Flag Coverage Δ
unit-tests 79.20% <ø> (+2.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah changed the title feat: Set Session Replay mutation observer to wait for DOMContentLoaded feat: Configure Session Replay to wait for DOMContentLoaded Aug 28, 2024
@metal-messiah metal-messiah enabled auto-merge (squash) August 28, 2024 23:01
@metal-messiah metal-messiah merged commit 84bd299 into main Aug 28, 2024
20 of 21 checks passed
@metal-messiah metal-messiah deleted the exp-bug-recorder branch August 28, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants