Skip to content

fix: safeguard api calls #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: safeguard api calls #1103

merged 1 commit into from
Jul 8, 2024

Conversation

patrickhousley
Copy link
Contributor

Adding a safeguard to prevent an exception from being thrown when browser agent APIs are called before the agent is fully initialized.

Overview

Adding a safeguard to prevent an exception from being thrown when browser agent APIs are called before the agent is fully initialized.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-276448
#1057

Testing

The issue cannot be reproduced.

Copy link

github-actions bot commented Jul 8, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 34.08 kB / 11.87 kB (gzip) 34.16 kB / 11.9 kB (gzip) 0.25% / 0.25% (gzip)
lite async-chunk 50.09 kB / 16.18 kB (gzip) 50.09 kB / 16.18 kB (gzip) 0% / 0% (gzip)
pro loader 54.74 kB / 18.52 kB (gzip) 54.83 kB / 18.56 kB (gzip) 0.16% / 0.16% (gzip)
pro async-chunk 96.73 kB / 28.99 kB (gzip) 96.73 kB / 28.99 kB (gzip) 0% / 0% (gzip)
spa loader 62.68 kB / 20.94 kB (gzip) 62.77 kB / 20.97 kB (gzip) 0.14% / 0.14% (gzip)
spa async-chunk 111.84 kB / 33.37 kB (gzip) 111.84 kB / 33.37 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 127.69 kB / 41.18 kB (gzip) 127.79 kB / 41.22 kB (gzip) 0.08% / 0.11% (gzip)
lite-polyfills async-chunk 63.99 kB / 18.45 kB (gzip) 63.99 kB / 18.45 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 150.07 kB / 47.46 kB (gzip) 150.17 kB / 47.51 kB (gzip) 0.06% / 0.1% (gzip)
pro-polyfills async-chunk 116.72 kB / 31.22 kB (gzip) 116.72 kB / 31.22 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 158.27 kB / 49.62 kB (gzip) 158.37 kB / 49.67 kB (gzip) 0.06% / 0.09% (gzip)
spa-polyfills async-chunk 133.69 kB / 35.92 kB (gzip) 133.69 kB / 35.92 kB (gzip) 0% / 0% (gzip)

Copy link

github-actions bot commented Jul 8, 2024

Static Badge

Last ran on July 08, 2024 12:06:31 CDT
Checking merge of (68ca11e) into main (83d7d1e)

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (83d7d1e) to head (68ca11e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   87.66%   87.62%   -0.04%     
==========================================
  Files         162      162              
  Lines        7256     7259       +3     
  Branches     1422     1423       +1     
==========================================
  Hits         6361     6361              
- Misses        780      782       +2     
- Partials      115      116       +1     
Flag Coverage Δ
integration-tests 91.43% <100.00%> (-0.02%) ⬇️
unit-tests 76.43% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickhousley patrickhousley merged commit 3d815a3 into main Jul 8, 2024
32 of 34 checks passed
@patrickhousley patrickhousley deleted the api-undefined branch July 8, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants