-
Notifications
You must be signed in to change notification settings - Fork 51
fix: Undefined stns in blob Trace #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 87.02% 87.38% +0.35%
==========================================
Files 156 156
Lines 7098 7100 +2
Branches 1393 1394 +1
==========================================
+ Hits 6177 6204 +27
+ Misses 797 779 -18
+ Partials 124 117 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending test suite run
Fix an instance of undefined error in Session Trace feature introduced in v1.259.0. Harvest will now no longer be attempted if there are no trace nodes to send.
Overview
Fix a scenario wherein
stns
is undefined and causing problem when.length
property is accessed for it. Instead, prepareHarvest will early exit when such is the case.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-270488
Testing
Component test added