[nr-k8s-otel-collector] Add DaemonSet and Deployment container port configuration options #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| metrics: | ||
| enabled: true | ||
| containerPort: 8888 | ||
| servicePort: 8888 |
There was a problem hiding this comment.
servicePort is being ignored by the tpl function. Do we need to support this parameter?
There was a problem hiding this comment.
@dbudziwojskiNR we should probably adopt what the OTel Collector chart is doing.
The servicePort just gets added to the associated service for the OTel Collector from what I can tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Adds the ability for users to specify what container ports need to be open for both the DaemonSet and Deployment. For example, if a user wants to collect OTel internal telemetry, port 8888 needs to be open.
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])