Skip to content

implement fixes #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

implement fixes #495

merged 3 commits into from
Nov 13, 2024

Conversation

walshmm
Copy link
Collaborator

@walshmm walshmm commented Nov 8, 2024

Description of work

please refer to ticket.

To test

please refer to ticket.

Link to EWM item

EWM#7766

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • In reduction, when user selects "retain Unfocused Data", make the default ConvertUnits request dSpacing instead of the current `undefined
  • User can enter run number in reduction workflow by pressing the "enter" key in addition to the current option to press button to enter run number
  • Make the reduction tab the default (i.e. tab order would be Reduction, Difcal, then Normcal

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (7f8c2e4) to head (7e7c2f1).
Report is 47 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #495      +/-   ##
==========================================
+ Coverage   96.53%   96.54%   +0.01%     
==========================================
  Files          64       64              
  Lines        4815     4836      +21     
==========================================
+ Hits         4648     4669      +21     
  Misses        167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walshmm walshmm marked this pull request as ready for review November 8, 2024 20:29
Copy link
Contributor

@rboston628 rboston628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reviewing this with the understanding that item 0 from EWM7766 is to be implemented in a separate story pending UI input from Malcolm.

Open the calibration panel. Reduction is the first tab.
image

I type a run number and press the enter key, and there it goes
image

When I click to retain unfocused data, it defaults to wavelength and not dspacing
image

Copy link
Contributor

@rboston628 rboston628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else still works, and now dSpacing is the default unit
image

@walshmm walshmm merged commit bb8cf23 into next Nov 13, 2024
8 checks passed
@walshmm walshmm deleted the ewm7766_assorted_fixes branch November 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants