Replace Pixel DiffCal Algorithm with Recipe #466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This is part of Epic 4161
This epic requires splitting the diffcal process into the pixel part and the grouped part.
This PR is responsible for splitting off the pixel part. Consistent with a discussion on the proper use of Recipe/Algorithm, this turns the pixel diffcal process into a recipe, which is more appropriate.
Explanation of work
All of the functionality from the algorithm was moved into this recipe. The new recipe will handle its own convergence process.
The DiffractionCalibrationRecipe now calls this recipe instead of the algorithm, and does not need to call it iteratively.
All of the tests were adapted to work with this recipe. Divergences should be minimal.
Two of the tests of the DiffractioncalibrationRecipe are no longer applicable there, but are moved as tests of the PixelDiffCalRecipe.
To test
Dev testing
Check the tests. Make sure the changes are minimal and only the necessary changes to account for the new process.
The tests are changed in-place, to make it easier to review. They should be renamed and moved almost as soon as this PR is approved.
Perform the usual manual testing checks.
CIS testing
This is an enabler.
Link to EWM item
EWM#7511
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.