-
Notifications
You must be signed in to change notification settings - Fork 124
Pin setuptools to a known working version #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ 773adc7 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3007 +/- ##
==========================================
- Coverage 67.28% 67.28% -0.01%
==========================================
Files 572 572
Lines 104965 104968 +3
==========================================
Hits 70627 70627
- Misses 34338 34341 +3 ☔ View full report in Codecov by Sentry. |
Why do we install |
See #2706 for why we need a specific version of |
Sad but ok. |
Same as #3006 but for master.
The problem happens when we build the docs (see for example here), with the strange stack trace:
I think the problem is this setuptools commit, in which they start using
from packaging.utils import canonicalize_version
, and since we installpackaging==21.2
(see #2706 for the explanation), which doesn't have the argumentstrip_trailing_zero
, we get the error above. Using an older version of setuptools fixes the issue.