Skip to content

fix: omit duplicate functions from list of bundled files #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Jul 9, 2025

Summary

Recreating #3795

When printing the list of bundled functions, Netlify Build uses zip-it-and-ship-it's listFunctions method, which includes functions that have not been bundled due to a naming conflict (e.g. when both function.js and function.ts are found). Because of this, Netlify Build was incorrectly reporting that both functions were bundled, when in fact only function.js was.

This PR removes those duplicate functions from the list


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Contributor

github-actions bot commented Jul 9, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork changed the title test: failing test for duplicate function names fix: omit duplicate functions from list of bundled files Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork marked this pull request as ready for review July 9, 2025 19:19
@mrstork mrstork requested a review from a team as a code owner July 9, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant