Adhere to DCM 1.28.1 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the package version to 17.0.0 in order to adhere to DCM 1.28.1 and introduces several new lint rules for improved code quality.
- Updated version in pubspec.yaml
- Added new lint metrics in dcm.yaml
- Updated CHANGELOG.md to reflect the new version and changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/netglade_analysis/pubspec.yaml | Updated the package version to 17.0.0 |
| packages/netglade_analysis/lib/dcm.yaml | Added new lint rules to enforce additional code quality standards |
| packages/netglade_analysis/CHANGELOG.md | Documented the new version and summarized the new lint rules added |
Comments suppressed due to low confidence (1)
packages/netglade_analysis/lib/dcm.yaml:135
- [nitpick] Consider renaming 'avoid-recursive-tostring' to 'avoid-recursive-to-string' for improved readability and consistency with similar lint rule naming conventions.
- avoid-recursive-tostring
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to adhere to DCM 1.28.1 by bumping dependency versions and adding new lint rules.
- Updated the netglade_analysis dependency across multiple packages from ^16.x to ^17.0.0.
- Added several new lint rules to packages/netglade_analysis/lib/dcm.yaml.
- Updated the global DCM version in dcm_global.yaml.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/netglade_utils/pubspec.yaml | Updated netglade_analysis dependency version to ^17.0.0 |
| packages/netglade_utils/example/pubspec.yaml | Updated netglade_analysis dependency version to ^17.0.0 |
| packages/netglade_flutter_utils/pubspec.yaml | Updated netglade_analysis dependency version to ^17.0.0 in dev_dependencies |
| packages/netglade_flutter_utils/example/pubspec.yaml | Updated netglade_analysis dependency version to ^17.0.0 in the dependency section |
| packages/netglade_analysis/pubspec.yaml | Updated package version to 17.0.0 |
| packages/netglade_analysis/lib/dcm.yaml | Added new lint rules in accordance with DCM 1.28.1 |
| packages/netglade_analysis/README.md | Updated dev dependency version for netglade_analysis to ^17.0.0 |
| packages/netglade_analysis/CHANGELOG.md | Documented changes for version 17.0.0 adhering to DCM 1.28.1 |
| dcm_global.yaml | Updated global DCM version from "1.27.1" to "1.28.1" |
DCM report✅ no issues found! Full report: https://github.com/netglade/flutter_core/runs/40941851572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.