"Update" for non-uppercase primary_mac_address reported even when not changed

[ruffy91]

Diode version

v1.4.0

Deployment type

docker compose

Deployment type version

docker compose

Diode SDK type

diode-sdk-python

Diode SDK version

v1.1.0

Diode NetBox Plugin version

v1.2.0

NetBox version

v4.3.3

Steps to reproduce

When sending a VMMachine containing a VMInterface with a primary_mac_address or a Device containing a Interface with a primary_mac_address then changes will be generated and sent to netbox even when the MAC did not change.

Expected behavior

There is no change reported to netbox

Observed behavior

A change is reported to netbox:

The following update is logged with DEBUG loglevel:

{
"id": "6b628c6e-609f-4e9f-8089-57d72e5ba0ba",
"errors": null,
"change_set": {
"id": "6b628c6e-609f-4e9f-8089-57d72e5ba0ba",
"changes": [
{
"id": "e6744052-eb68-4ecf-83cf-b976a4bd6a96",
"change_type": "update",
"object_type": "dcim.macaddress",
"object_id": 687,
"ref_id": null,
"object_primary_value": "9c:1d:36:fc:96:2f",
"before": {
"assigned_object_id": 27,
"assigned_object_type": "dcim.interface",
"id": 687,
"mac_address": "9C:1D:36:FC:96:2F"
},
"data": {
"assigned_object_id": 27,
"assigned_object_type": "dcim.interface",
"id": 687,
"mac_address": "9c:1d:36:fc:96:2f"
},
"new_refs": []
}
],
"branch": null
}
}

[jajeffries]

Is the mac address being sent to diode in lowercase? If so, try converting it to uppercase first and see if you still get the same issue.

[ruffy91]

Uppercasing the mac address before sending it helps. No unnecessary updates happen.

The entity was created by sending the mac address in lower case in the first case and was upper cased automagically. As such I would expect it to work the same when sending the same mac address again.

[ltucker]

Likely fix is to add a normalization for mac address fields in the diode-plugin diff generation to the way NetBox likes to store it (and double check mac address matching is also appropriately case insensitive).