Skip to content

[management] fix lastLogin on dashboard #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 10:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new function to retrieve user details from the authentication context to support updates related to the user's lastLogin on the dashboard. Key changes include:

  • Adding a new function type GetUserFromUserAuthFunc in the middleware.
  • Updating the AuthMiddleware struct and constructor to include getUserFromUserAuth.
  • Integrating a call to getUserFromUserAuth in the JWT validation process to update user information.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
management/server/http/middleware/auth_middleware.go Added new function type, field, and invoked getUserFromUserAuth to update user info.
management/server/http/handler.go Passed the new accountManager.GetUserFromUserAuth to the middleware.

@pascal-fischer pascal-fischer merged commit 986eb8c into main Apr 23, 2025
34 of 35 checks passed
@pascal-fischer pascal-fischer deleted the fix/last-login-on-dashboard branch April 23, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants