[management/client/rest] fix panic when body is nil #3714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamed-essam
force-pushed
the
fix/management-rest-panic
branch
from
5e994e0 to
99f9cc0
Compare
lixmal
approved these changes
Apr 23, 2025
|
@mohamed-essam can you merge main into the branch? |
mohamed-essam
force-pushed
the
fix/management-rest-panic
branch
from
99f9cc0 to
818df8e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes panic occurring when body is nil (this usually happens when connections is refused) due to lack of nil check by centralizing
response.Body.Close()behavior.Issue ticket number and link
netbirdio/kubernetes-operator#21
Stack
Checklist