[client] set TLS ServerName for hostname-based QUIC connections

[alindt]

This sets ServerName in the TLS config when using hostnames to fix the validation.

Issue ticket number and link

Potentially fixes #3672

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[CLAassistant]

All committers have signed the CLA.

[pappz]

The URL may not have a port number in the URL string. Could you support this scenario too?

[alindt]

@pappz Done.

[pappz]

@alindt
Modifying the prepareURL function is a little bit risky. We will lose the URL path.

I recommend that you create a function that figures out the serverName from the given URL string properly. I take a quick look to the WS package, the first step is the URL string will be converted to URL type and after that the net.SplitHostPort

[alindt]

@pappz I don't understand what you mean by "losing the URL path".

The only way the QUIC dialer uses quicURL is as a parameter for net.ResolveUDPAddr() which expects a host[:port] string, which is exactly what my changed prepareURL (still) does.

The only change is in appending the default ports as per your request, meaning it will always include a :port part.

Sorry, am I missing something?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pappz]

You are right. I mixed the things a little bit. I take a look again.

[B08Z]

You are right. I mixed the things a little bit. I take a look again.

Any update on if this will be pulled in.

I think it's stopping my clients connecting to relay using quic