meraki_appliance: Traffic_shaping & SD WAN Internet Policies Custom Performance Class and Depends On #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vozhyk-
reviewed
May 29, 2025
…raffic uplink preference handling
vozhyk-
reviewed
Jun 2, 2025
Co-authored-by: Witaut Bajaryn <[email protected]>
jon-humphries
force-pushed
the
feature-traffic-shaping-depends
branch
from
716db9e to
091cec7
Compare
jon-humphries
changed the title
vozhyk-
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add depends on logic to all traffic shaping modules.
The VLANs and Appliance must be added prior to configuring traffic shaping.
Having the VLAN applied first ensures that if it is referenced in the rules or definitions it is there prior to applying the rules.
Explicitly implies that a VLAN or Single VLAN must be configured first (which is a precursor to any Appliance deployment) and assumes the appliance must also have been added. You cannot add a VLAN or Single LAN address without adding an appliance to the inventory.
Add mapping from
custom_performance_class_nameto ID in:networks_appliance_traffic_shaping_uplink_selection;networks_appliance_sdwan_internet_policies.