Change to GraalVM instead og Nashorn #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorHarbo
added
enhancement
dependencies
|
Converted to draft as I found a mistake. This update will make the porject not build on java 11 as it is right now. |
|
I've updated the first comment of this PR as it is now ready. We are not including Nashorn in the POM. I've changed to use GraalVM instead. |
VictorHarbo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building solrwayback with java versions above 15 fails the test class
JavascriptTests.This can be mitigated by changing which JavaScript engine is used to run these tests. Nashorn is discontinued in java 15+ and most services are changing to use GraalVM instead. This PR removes Nashorn and changes to GraalVM, which makes it possible to pass these tests on Java versions before and after 15. I've tested on 11 and 19.