Skip to content

fix(core): HTTP adapter error mapping #15056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

fix(core): HTTP adapter error mapping #15056

merged 1 commit into from
May 8, 2025

Conversation

maxbronnikov10
Copy link

@maxbronnikov10 maxbronnikov10 commented May 2, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

FastifyError instance did not mapped to HttpException which broke conditions in ExceptionFilter

Issue Number: #15022

What is the new behavior?

Added handler for FastifyError in mapping function in RoutesResolver.

Does this PR introduce a breaking change?

  • Yes
  • No

@maxbronnikov10 maxbronnikov10 force-pushed the fix/http-adapter-error branch from cc3b138 to 76d9d3d Compare May 2, 2025 02:30
@maxbronnikov10 maxbronnikov10 changed the title fix: HTTP adapter error mapping fix(core,express,fastify): HTTP adapter error mapping May 2, 2025
@coveralls
Copy link

coveralls commented May 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build cdb8c545-83c0-47d9-b846-7251e4e54cdd

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 41 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.926%
Files with Coverage Reduction New Missed Lines %
packages/microservices/server/server-rmq.ts 19 62.25%
packages/microservices/client/client-rmq.ts 22 65.84%
Totals Coverage Status
Change from base Build ed79855f-0323-482d-b990-7ee9bd2efe0c: -0.01%
Covered Lines: 7179
Relevant Lines: 8073
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec mentioned this pull request May 5, 2025
Closed
2 tasks
kamilmysliwiec
kamilmysliwiec reviewed May 5, 2025
View reviewed changes
@maxbronnikov10
Copy link
Author

New PR with refactoring - #15075

@maxbronnikov10 maxbronnikov10 force-pushed the fix/http-adapter-error branch from 76d9d3d to 72a4925 Compare May 5, 2025 21:33
@maxbronnikov10 maxbronnikov10 changed the title fix(core,express,fastify): HTTP adapter error mapping fix(core): HTTP adapter error mapping May 5, 2025
@maxbronnikov10 maxbronnikov10 force-pushed the fix/http-adapter-error branch 2 times, most recently from ddfa8c8 to d1b523b Compare May 5, 2025 21:37
kamilmysliwiec
kamilmysliwiec reviewed May 6, 2025
View reviewed changes
@maxbronnikov10 maxbronnikov10 force-pushed the fix/http-adapter-error branch 2 times, most recently from abc3d7f to ac16d93 Compare May 6, 2025 20:39
@maxbronnikov10 maxbronnikov10 force-pushed the fix/http-adapter-error branch from ac16d93 to fb3b12d Compare May 6, 2025 20:40
@kamilmysliwiec kamilmysliwiec merged commit 7338c03 into nestjs:master May 8, 2025
3 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

Assignees
No one assigned
Labels
scope: core type: bug 😭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxbronnikov10 @coveralls @kamilmysliwiec