Skip to content

fix(microservices): ensure all redis connections are closed #15020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yatin166
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Redis connection were not properly closed for pub/sub client due to missing async/await

Issue Number: N/A

What is the new behavior?

Added async/await when quit() is called for pub/sub client for server-redis so that all the connections are properly closed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 86d5e97b-167a-4f3d-9926-ffc87674aec5

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.923%

Totals Coverage Status
Change from base Build c493f148-f1dd-4b7d-a940-d13270fde234: 0.0%
Covered Lines: 7177
Relevant Lines: 8071

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 296ddd5 into nestjs:master Apr 28, 2025
3 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants