Skip to content

fix(microservices): to nack when there is no matching handler #11642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2023

Conversation

ryoctrl
Copy link
Contributor

@ryoctrl ryoctrl commented May 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This PR is a proposal for the following issue.

#11641

When a nest application which connected with RabbitMQ receives a unknown message(it meant that there is no matching handler in a controller), it will negative acknowledge a received message without retrying.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented May 19, 2023

Pull Request Test Coverage Report for Build 6f4a13f0-69fc-47af-8136-bf372876b395

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 92.634%

Totals Coverage Status
Change from base Build ef3ef350-fcca-4de2-8599-e75b53ebe148: 0.007%
Covered Lines: 6527
Relevant Lines: 7046

💛 - Coveralls

@ryoctrl ryoctrl force-pushed the nack_when_no_matching_handler branch 3 times, most recently from 6af8b16 to 15346fc Compare May 19, 2023 19:37
@kamilmysliwiec kamilmysliwiec merged commit 9004a4a into nestjs:master May 23, 2023
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants