begin using emmylua_ls #33344
begin using emmylua_ls #33344
Conversation
github-actions
bot
added
build
This comment was marked as resolved.
This comment was marked as resolved.
lewis6991
force-pushed
the
feat/emmyluals
branch
2 times, most recently
from
5d4ea53 to
e2b14a6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -88,6 +88,7 @@ local function modifiers_from_number(x, modifiers_table) | |||
| return modifiers | |||
| end | |||
|
|
|||
| --- @async | |||
There was a problem hiding this comment.
What are the implications of this?
There was a problem hiding this comment.
Any function that has a route to coroutine.yield() is marked by the tool as async. The @async annotation is make this explicit. This helps find bugs where the code is called from the main thread but acidentally enters a code path that may yield.
I've got gitsigns fully typed with @async here and have found it a very useful diagnostic as it finds places where functions that are expected to execute synchronously are calling async functions.
lewis6991
force-pushed
the
feat/emmyluals
branch
from
3d1334c to
c71353e
Compare
| emmylua-check: luv | ||
| -emmylua_check \ | ||
| --output-format=json \ | ||
| --config=$(PWD)/.luarc.json \ |
There was a problem hiding this comment.
You probably want to use CURDIR instead of PWD. The latter will be incorrect with make -C <path> (among other things). In fact, you basically never want to use PWD.
Explained well here: https://stackoverflow.com/a/52447088
There was a problem hiding this comment.
Thanks. I'll make sure to use CURDIR instead from now on. This target is only temporary. The final form will be in cmake.
lewis6991
force-pushed
the
feat/emmyluals
branch
2 times, most recently
from
948aad6 to
fd6d0ea
Compare
lewis6991
force-pushed
the
feat/emmyluals
branch
5 times, most recently
from
18c8ba4 to
3d1ea3b
Compare
lewis6991
force-pushed
the
feat/emmyluals
branch
2 times, most recently
from
80fd0e2 to
ee1639f
Compare
I don't plan on merging this as-is, just a place to hold all the fixes so I can post issues upstream.
Once this gets big enough, I'll cherry pick all the changes which are LuaLS compatible.