Update stable snap to use stable branch, works for v0.10 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the snapcraft.yaml file selects the stable tag based on a regex to identify versioned releases and sorting them to find the latest stable release. However, it uses a string/alphanumeric sort, which stopped working with version 0.10 of Neovim. At that point, this sorting approach deemed 0.10.0 to be less than 0.9.5. This changes the tag to simply be "stable", which points to the stable tag. Test Plan: ``` Generated snap metadata Lint OK: - classic: Snap confinement is set to classic. Lint warnings: - classic: usr/bin/nvim: ELF interpreter should be set to '/snap/core22/current/lib64/ld-linux-x86-64.so.2'. (https://snapcraft.io/docs/linters-classic) Created snap package nvim_v0.10.0_amd64.snap ```
Closed
|
Thanks for the clear explanation. "stable" is a tag not a branch, but it looks like you considered that, so I'll assume this will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the snapcraft.yaml file selects the stable tag based on a regex to identify versioned releases and sorting them to find the latest stable release. However, it uses a string/alphanumeric sort, which stopped working with version 0.10 of Neovim. At that point, this sorting approach deemed 0.10.0 to be less than 0.9.5.
This changes the tag to simply be "stable", which points to the stable tag.
Test Plan: