Skip to content

Basic CMake Support & Code Style clean-up #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stevefan1999-personal
Copy link
Contributor

@stevefan1999-personal stevefan1999-personal commented Dec 31, 2018

Some other work:

  • Change to C11 so we could use C11 threads to support more platforms? (Particularly Windows)
  • Remove CLion settings because it is too subjective?
  • Move JS system modules into a packed form with rollup for internal package to create embedded environment on to fly. We should use miniz to compress it and deflate it in runtime.
  • Move git submodules to CMake packages
  • Use https://github.com/Samsung/libtuv instead of hand-rolled event loop

@ThomasRogg
Copy link
Member

Thank you! Will take a look at the contribution this week.

@ThomasRogg
Copy link
Member

Hey!
This look like good work.
I have the problem however, that our team uses plain Makefiles only. None of us have expertise with CMake... and we do not want to pull things we will not maintain..
So right now, I have to keep this pull request in a waiting state...sorry. Maybe our team will grow this year :-)
Thomas

@jayarjo
Copy link

jayarjo commented Jan 29, 2019

Change to C11 so we could use C11 threads to support more platforms?

Does the fact that this one is checked out mean that Windows support is near?

@ThomasRogg
Copy link
Member

Just noted the check box and that I can select/deselect them.
Not sure who selected them, me? Sorry!

Linux support is primary to provide a test system for development on PCs which behaves like it does on ESP32 later. For this Linux suffices, so Windows is not a priority.

None of the points above are a priority for us 3 core developers, as we have the goal of creating the best ESP32 system. For this, other things have higher priority.

If anybody wants to spend time developing low.js in any other direction, great! And we would be happy to integrate the changes. The problem with this CMake work however is that we as core devs must first understand CMake... But we want to give it a try sometime in the future.

@tiendq
Copy link

tiendq commented May 10, 2019

@neoniousTR I understand that Makefiles is still popular used but unsurprisingly CMake is becoming the most favorite build tool for C++ nowadays too, mainly because it saves our time. Looking at an open source project? it's nice to know you can build it easily with some trivial (and familiar) commands mkdir build, cd build, cmake .., make :)

@ThomasRogg
Copy link
Member

That is all correct. But for us it does not save time yet, as we have nobody who will use the CMake system right now. See my last message :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants