Update to PHPUnit 7 #908
Merged
Update to PHPUnit 7 #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
commented
Mar 26, 2018
| @@ -83,7 +83,7 @@ public function testReturnsUniqueValueIfUniqueFlagsFound() | |||
| $result = $denormalizer->denormalize($fixture, $flags, $value); | |||
|
|
|||
| $this->assertInstanceOf(UniqueValue::class, $result); | |||
| $this->stringContains('dummy_id', $result->getId()); | |||
| $this->assertStringStartsWith('Dummy#', $result->getId()); | |||
There was a problem hiding this comment.
Was stringContains use in purpose?
There was a problem hiding this comment.
I'm fine with changing this if this is a issue I don't think there was a strong reasons for it.
|
👍 tests seems to be failing with lowest deps though. It looks like we might need to dump the minimal requirements of some deps (likely to be phpunit bridge but that would need to be checked) |
|
@theofidry Sure, gonna look into that and update this PR ASAP :) Edit: fixed 👍 |
|
Great, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.