This repository was archived by the owner on Apr 6, 2020. It is now read-only.
Copy min/max Value properties #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the minValue and maxValue properties on QBValidationRangeRule were set to assign. Which meant that whoever created this rule was in charge of keeping reference to these objects until the rule finished running. This practice is not consistent with the interface designed by QBValidator. The use case is defined to use the macro functions as such ``` QBVLessThan(@(10)) QBVInRange(10, 20) ``` In the examples above, nobody is keeping hold of the `@(10)`. So we basically enter into a race condition. The device could reassign that pointer without our knowledge and cause a crash whenever the comparisons are made. The fix is to simply copy these values, so the rule has a dedicated reference to the pointers that will be around for the lifetime of the rule.
|
+1 |
3 similar comments
|
+1 |
|
👍 |
|
👍 |
|
👍 👍 |
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the minValue and maxValue properties on QBValidationRangeRule were set to assign. Which meant that whoever created this rule was in charge of keeping reference to these objects until the rule finished running.
This practice is not consistent with the interface designed by QBValidator. The use case is defined to use the macro functions as such
In the examples above, nobody is keeping hold of the
@(10). So we basically enter into a race condition. The device could reassign that pointer without our knowledge and cause a crash whenever the comparisons are made.The fix is to simply copy these values, so the rule has a dedicated reference to the pointers that will be around for the lifetime of the rule.