Add Support for the Gnome41 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neffo
requested changes
Oct 17, 2021
|
Thanks for this. There's a few more things that need fixing up to get this approval of the GNOME extension. Some of the other code is using older techniques that are no longer needed so I will have to port that over as well. |
I changed that on my branch I am not experienced in js neither on the gnome standards, but if you could link the docs where the newer techniques are explained, I might be able to help : ) |
|
An overview is here: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review |
|
Sure, if you'd like to help I would gladly accept. I can merge this fix into the new branch for the moment, and document some of fixes needed. See #26 |
neffo
added a commit
that referenced
this pull request
Oct 24, 2021
Changes in this version: - update metadata.json, fix point release support - add support for the Gnome41 #25 - replace all references to Lang.bind() (13) - update build script to remove unnecessary files (.po, .h, etc) - move all code within class (nothing in init() or in global scope other than localization) - fix tray icon switching - remove non-functional map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues that I created #24 .
It works perfectly on my machine, don't know if you do any type of testing ...