You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The amount of "byte-juggling" that has evolved in the driver is getting a bit out of hand, consider defining some structs for input (and output) reports instead of passing around PVOID or PUCHAR everywhere and having the need to sprinkle around comments on which byte and bit offset identifies which button, axis etc.
This will also make it easier to write new translation functions if more modes get added.
Using structures instead of byte-counted/void pointers will also fix some Code Analysis Warnings that are false-positives.
Move those to a "public" header file to be consumed by #66 and similar solutions.
The text was updated successfully, but these errors were encountered:
The amount of "byte-juggling" that has evolved in the driver is getting a bit out of hand, consider defining some
struct
s for input (and output) reports instead of passing aroundPVOID
orPUCHAR
everywhere and having the need to sprinkle around comments on which byte and bit offset identifies which button, axis etc.This will also make it easier to write new translation functions if more modes get added.
Using structures instead of byte-counted/void pointers will also fix some Code Analysis Warnings that are false-positives.
Move those to a "public" header file to be consumed by #66 and similar solutions.
The text was updated successfully, but these errors were encountered: