Skip to content

Add supportive (strong) types for HID reports #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nefarius opened this issue Apr 18, 2021 · 0 comments
Closed

Add supportive (strong) types for HID reports #72

nefarius opened this issue Apr 18, 2021 · 0 comments
Assignees
Labels
Core Core/Common Driver Topic enhancement New feature or request

Comments

@nefarius
Copy link
Owner

The amount of "byte-juggling" that has evolved in the driver is getting a bit out of hand, consider defining some structs for input (and output) reports instead of passing around PVOID or PUCHAR everywhere and having the need to sprinkle around comments on which byte and bit offset identifies which button, axis etc.

This will also make it easier to write new translation functions if more modes get added.

Using structures instead of byte-counted/void pointers will also fix some Code Analysis Warnings that are false-positives.

Move those to a "public" header file to be consumed by #66 and similar solutions.

@nefarius nefarius added enhancement New feature or request Core Core/Common Driver Topic labels Apr 18, 2021
@nefarius nefarius self-assigned this Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core/Common Driver Topic enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant