Skip to content

fix(AnimatedStyle): runtime error when passing undefined transform style #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(AnimatedStyle): runtime error when passing undefined transform style #2530

wants to merge 1 commit into from

Conversation

tarunrajput
Copy link
Contributor

Fixes: #2523
If passing undefined to Animated.View transform style, there will be a runtime error. This issue does not happen on react-native-web 0.18.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 31, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tarunrajput
Copy link
Contributor Author

tarunrajput commented May 31, 2023 •
edited
Loading

@necolas, as per RN docs, transform accepts an array of transformation objects or space-separated string values. But I am getting same runtime error with string values when using Animated transformations because AnimatedTransform only accepts Array of Objects

image

@tarunrajput tarunrajput force-pushed the fix/createAnimatedStyles branch from f47da45 to 52dd4a6 Compare May 31, 2023 11:54
@humaidk2 humaidk2 mentioned this pull request Jun 18, 2023
Closed
12 tasks
necolas added a commit that referenced this pull request Jun 27, 2023
@necolas
[fix] Animated support for string transforms
ed83baa 
Fix #2528
Fix #2523
Close #2546
Close #2530
@necolas necolas closed this in 869c416 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Animated] Regression runtime error if passing undefined to Animated.View style
1 participant
@tarunrajput