Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

Wildcard module declaration #802

@luixo

Description

@luixo

Story

As a newcomer to this repository, I'm pretty confused with declaration declare module "*" in typescript extraneous declaration file.
It seems like a smelly code for me, combining with no monorepo tooling it caused an irritating bug of every module being linked to this declaration, effectively ruining all type checks.

Seems like this line was added to help out with absent type on datamaps module, but probably it was an overkill to add a wildcard for that.

Proposals

  • Replace wildcard module definition to datamaps module definition
  • Either update datamaps to 0.5.9 which has type definitions and write own react components or make a PR with types to react-datamaps package (propose your own solution!)
  • Be more strict on wildcards in general :)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions