Rename signEvent to getSignature #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with you, but I'm afraid this will break too much. Maybe we should keep both for a while and change the docs and add a deprecation notice or something, then remove it after 6 months? |
|
Good call. I updated the branch and restored the |
alexgleason
force-pushed
the
get-signature
branch
from
1f91a6a to
f869a80
Compare
alexgleason
force-pushed
the
get-signature
branch
from
f869a80 to
552530f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
signEventfunction is named incorrectly. It should be calledgetSignature, which matches its partner functiongetEventHash. This is because it returns a string instead of a signed event. Even NIP-07'swindow.nostr.signEventfunction is correct, returning the signed event, but the one in this repo isn't.This is a breaking change, but I think it's needed. The name of this function interferes with actual
signEventimplementations.