Skip to content

Moves all Validated Software assigned items to tabs #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

joewesch
Copy link
Contributor

@joewesch joewesch commented Apr 1, 2025

Closes: #441

What's Changed

This PR changes the Validated Software detail view to move the lists of assigned items to separate tabs.

Before

Screenshot 2025-04-01 at 2 47 13 PM
Screenshot 2025-04-01 at 2 47 17 PM
Screenshot 2025-04-01 at 2 47 23 PM

After

Main tab

Screenshot 2025-04-01 at 3 35 17 PM

Individual tabs

Screenshot 2025-04-01 at 3 35 27 PM
Screenshot 2025-04-01 at 3 35 33 PM
Screenshot 2025-04-01 at 3 35 38 PM
Screenshot 2025-04-01 at 3 35 44 PM
Screenshot 2025-04-01 at 3 35 49 PM

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@itdependsnetworks
Copy link

does it make sense to use nautobot.core.ui.object_detail.ObjectsTablePanel here?

Here is an example of it in use: https://github.com/nautobot/nautobot/pull/6962/files#diff-caf8a412a9f30295cacfae888c0fbc1bdc2a7cd2643df55f444414f363113a7bR1392-R1398

it already paginates and handles a bunch more.

@joewesch
Copy link
Contributor Author

joewesch commented Apr 2, 2025

I'm open to changing it, I was just moving what already existed for performance reasons. I do feel like that's a lot of screen real estate with so many tables on the right side of the page, so maybe a combination of the new tab along with the ObjectsTablePanel?

Thoughts @progala?

@progala
Copy link
Contributor

progala commented Apr 9, 2025

nautobot.core.ui.object_detail.ObjectsTablePanel requires Nautobot 2.4.0+ . DLM 3.0.0 supports 2.2.0+, and I don't think we're going to move straight to Nautobot 2.4.0+ in DLM 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validated software detail view timeout at scale
3 participants