Skip to content

Fix build and run tests on newer java versions. #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix build and run tests on newer java versions. #346

merged 1 commit into from
Oct 15, 2020

Conversation

jameshilliard
Copy link
Contributor

No description provided.

@jameshilliard jameshilliard force-pushed the travis-jdk branch 4 times, most recently from d3e75fa to 5576a5d Compare October 9, 2020 23:51
@jameshilliard
Copy link
Contributor Author

It seems some of these tests have a high percentage of spurious failures that appear unrelated to these changes, I managed to get them all passing here in my personal travis.

@jameshilliard jameshilliard force-pushed the travis-jdk branch 5 times, most recently from b64c06f to f619b7a Compare October 11, 2020 05:20
@jameshilliard jameshilliard mentioned this pull request Oct 11, 2020
Closed
RichardHightower
RichardHightower approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@RichardHightower RichardHightower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColinSullivan1 ColinSullivan1 self-requested a review October 15, 2020 22:20
ColinSullivan1
ColinSullivan1 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Your contribution and time here is greatly appreciated! Many thanks! I spotted a few small things that were pre-existing - those can be addressed outside of this PR.

@ColinSullivan1 ColinSullivan1 merged commit 1a0ed3f into nats-io:master Oct 15, 2020
@jameshilliard jameshilliard deleted the travis-jdk branch October 16, 2020 03:22
@jameshilliard jameshilliard mentioned this pull request Oct 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardHightower RichardHightower RichardHightower approved these changes

@ColinSullivan1 ColinSullivan1 ColinSullivan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameshilliard @RichardHightower @ColinSullivan1