Skip to content

Start 2.18.2 #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2024
Merged

Start 2.18.2 #1152

merged 2 commits into from
May 20, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented May 20, 2024

No description provided.

CHANGELOG.md Outdated

2.18.0 and 2.17.7 are identical.

2.18.0 attempts to start us on the road to properly [Semantic Version (semver)](https://semver.org/). In the last few patch releases, there were technically things that should cause a minor version bump, but were numbered as a patch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"there were technically things that should cause a" ---> "changes that should have been exposed via a minor version bump"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - LGTM

@scottf scottf merged commit 7119a1a into main May 20, 2024
2 checks passed
@scottf scottf deleted the start-2-18-2 branch May 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants