breaking: nats-server 2.10.26 emits no responder if stream/consumer are not found #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aricart
changed the title
aricart
force-pushed
the
fix-no-responders
branch
from
f6ae5d4 to
c938c7e
Compare
caspervonb
approved these changes
Mar 14, 2025
jetstream/consumer.ts
Outdated
| @@ -411,6 +420,17 @@ export class PullConsumerMessagesImpl extends QueuedIteratorImpl<JsMsg> | |||
| this.stop(error); | |||
| return; | |||
| } | |||
| } else if (code === 503 && description === "unknown") { | |||
There was a problem hiding this comment.
Isn't matching on 503 enough?
aricart
force-pushed
the
fix-no-responders
branch
from
c938c7e to
fca4bef
Compare
Signed-off-by: Alberto Ricart <[email protected]>
aricart
force-pushed
the
fix-no-responders
branch
from
fca4bef to
5e441c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullThe logic for reset when the consume fails due to missing heartbeats, will reduce the number of consumer infos done on non-bound consumers with a backoff that matches the expires. So the client will try quickly at first, but will settle to 30s by default tries.