[FIXED] Fix DeliverLastPerSubject consumer policy with interior deletes
#7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the consumer was trying to find the next message from a skiplist, we were not correctly moving `o.sseq` up to the next skiplist sequence, which would result in missed messages and some acks being ignored. This is particularly evident with interior deletes, such as those created by the `MaxMsgsPerSubject` limit which the unit test uses. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Jun 25, 2025
Includes the following: - #7003 - #7005 - #7006 Signed-off-by: Neil Twigg <[email protected]>
wallyqs
changed the title
DeliverLastPerSubject consumer policy with interior deletesDeliverLastPerSubject consumer policy with interior deletes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the consumer was trying to find the next message from a skiplist, we were not correctly moving
o.ssequp to the next skiplist sequence, which would result in missed messages and some acks being ignored. This is particularly evident with interior deletes, such as those created by theMaxMsgsPerSubjectlimit which the unit test uses.Signed-off-by: Neil Twigg [email protected]