[IMPROVED] Optimise needAck with new SubjectForSeq store function
#6990
+118
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/needack
branch
from
445855c to
5d177ae
Compare
neilalexander
force-pushed
the
neil/needack
branch
from
5d177ae to
12411ad
Compare
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/needack
branch
from
12411ad to
b08b02a
Compare
wallyqs
changed the title
needAck with new SubjectForSeq store functionneedAck with new SubjectForSeq store function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
SubjectForSeqfunction to the filestore that copies less and performs fewer allocations compared toLoadMsg. This is then used insideneedAckwhen we don't know what the subject is for the sequence, i.e. when called fromcheckStateForInterestStream.There are more improvements that need to be made here but for now this will reduce the amount of garbage created by this process, and by extension, reduce GC pressure and CPU usage on large interest-based streams.
Signed-off-by: Neil Twigg [email protected]