[FIXED] Gateway: TLS configuration reload now applies to implicit remotes #6886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otes
When a config reload is issued and a server has implicit remote
gateways (that is, gateways that were gossiped and not explicitly
configured), the TLS changes were applied only to explicit remotes.
With this change, the changes to the main `tls{}` block will be
applied to implicit remotes.
Resolves #6875
Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a config reload is issued and a server has implicit remote gateways (that is, gateways that were gossiped and not explicitly configured), the TLS changes were applied only to explicit remotes.
With this change, the changes to the main
tls{}block will be applied to implicit remotes.Credit to @song0071000 for the proposed changes in the code.
Resolves #6875
Signed-off-by: Ivan Kozlovic [email protected]