NRG: Stepping down from preferred candidate #6851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Apr 30, 2025
Includes the following: - #6851 - #6849 [skip ci] Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stream/consumer is already leader when it's R1. When it's scaled up, it remains leader and is preferred to be the leader of the Raft group. However, if it's in candidate state and doesn't get elected, it would not signal back to JetStream that it's not leader anymore once a new leader comes up.
This resulted in various weird situations where:
This is hard to reproduce normally, because the preferred leader nearly always gets elected.
Resolves #6838
Signed-off-by: Maurice van Veen [email protected]