De-flake TestJetStreamClusterConsumerAckSyncReporting
#6269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
neilalexander
added a commit
that referenced
this pull request
Dec 17, 2024
Includes the following: - #6269 - #6271 Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-flakes the test by using
checkFor.AckSynconly guarantees the ack was received, had quorum and is applied on the leader. It does not provided immediate consistency on all followers, so it might need some retries. Previouslyc.waitOnAllCurrent()was added but that only checks meta is current, not streams or consumers, so it would only wait for 100 milliseconds per server.Signed-off-by: Maurice van Veen [email protected]