Skip to content

Fix #8074: Prevent infinite spinner when root object provider is missing #8104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hasip-timurtas
Copy link

@hasip-timurtas hasip-timurtas commented Jun 26, 2025

Summary

This fixes issue #8074 by stopping the loading spinner when the root object provider is missing or unavailable

What Changed

  • Enhanced error handling in the MctTree component with try/catch around root and composition loading
  • Used finally to always set isLoading to false so the spinner stops
  • Checked for missing root objects and added a simple fallback view
  • Added warning logs when root objects are missing or have errors

Why It Matters

If the root provider was missing or returned bad data, the tree stayed stuck with a spinner. Now it shows an empty or error state instead 🚀

Testing

  • Missing root objects no longer cause an infinite spinner
  • Warning logs appear on errors
  • Tree shows fallback state when loading fails

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.10%. Comparing base (f4637b8) to head (257f82f).

Files with missing lines Patch % Lines
src/ui/layout/MctTree.vue 33.33% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8104      +/-   ##
==========================================
- Coverage   57.76%   57.10%   -0.66%     
==========================================
  Files         684      684              
  Lines       27560    27571      +11     
  Branches     2701     2702       +1     
==========================================
- Hits        15920    15745     -175     
- Misses      11306    11487     +181     
- Partials      334      339       +5     
Flag Coverage Δ
e2e-ci 63.23% <ø> (-0.01%) ⬇️
e2e-full 23.88% <ø> (-19.11%) ⬇️
unit 49.02% <33.33%> (-0.22%) ⬇️
Files with missing lines Coverage Δ
src/ui/layout/MctTree.vue 26.30% <33.33%> (-0.21%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4637b8...257f82f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Implement try-catch blocks for loading root and tree items to handle potential errors gracefully.
* Log warnings for missing root objects and ensure the tree displays an empty state instead of an infinite loading spinner.
* Maintain loading state management to improve user experience during data retrieval.
@hasip-timurtas hasip-timurtas force-pushed the fix/8074-infinite-spinner-missing-provider branch from 3578b6b to 257f82f Compare June 26, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant