All telemetry criteria bug

[akhenry]

Closes VIPERGC-816

Describe your changes:

• Renamed function argument for clarity.
• Code should default to a Map and not an associative array. Just create one once, don't initialize a new object every time we receive telemetry.
• Use Map getter function, not associative array key here and here
• Remove superfluous call to createNormalizedDatum
• Reverts a previous change to a unit test

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes? Yes - VIPERGC-816 regression test for condition sets bug akhenry/openmct-yamcs#495
• Has this been smoke tested?
• Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
• Have you associated a milestone with this PR? Note: leave blank if unsure.
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (gold@4aea6a5). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ugins/condition/criterion/AllTelemetryCriterion.js	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             gold    #8084   +/-   ##
=======================================
  Coverage        ?   57.15%           
=======================================
  Files           ?      678           
  Lines           ?    27494           
  Branches        ?     2694           
=======================================
  Hits            ?    15714           
  Misses          ?    11439           
  Partials        ?      341           

Flag	Coverage Δ
e2e-ci	62.82% <75.00%> (?)
e2e-full	23.59% <0.00%> (?)
unit	49.21% <75.00%> (?)

Files with missing lines	Coverage Δ
.../plugins/condition/criterion/TelemetryCriterion.js	78.94% <100.00%> (ø)
...ugins/condition/criterion/AllTelemetryCriterion.js	45.52% <66.66%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea6a5...eea3335. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shefalijoshi]

Ah! Because it's already normalized in ConditionManager. Nice!

[akhenry]

@shefalijoshi Since this is targeting gold already, it will be less work to merge this into gold and then cherry-pick the squash merge into master.