-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[CLA on File] style: added padding to object & icon button labels #6036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix for object names being cut off at the bottom
Codecov Report
@@ Coverage Diff @@
## master #6036 +/- ##
==========================================
- Coverage 55.25% 54.89% -0.36%
==========================================
Files 602 600 -2
Lines 24276 23599 -677
Branches 2147 2103 -44
==========================================
- Hits 13413 12954 -459
+ Misses 10257 10046 -211
+ Partials 606 599 -7
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
@taintedbones Thanks for taking a look at this! The fix works @ 100% zoom, which is awesome. Problem is still occurring at other zoom levels though. eg. |
@akhenry Thank you for the feedback! So I went back to check on this and couldn't replicate the issue on my branch. However, when I swapped over to master branch, the issue existed there. |
@taintedbones OK, let me take another look! Thanks. |
Have retested and this looks good to me. Sorry, I don't know what I did last time :) @charlesh88 This look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this branch is changing plot images in the e2e tests folder... CSS changes look good, and this is good to go once we clarify what's going on with e2e images.
@charlesh88: |
Closes #3822 #3568
Describe your changes:
Added 1px padding to the top and bottom of object & icon button labels. This fixes issues with labels being clipped on the bottom.All Submissions:
Author Checklist
Reviewer Checklist