Skip to content

[CLA on File] style: added padding to object & icon button labels #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

taintedbones
Copy link
Contributor

Closes #3822 #3568

Describe your changes:

Added 1px padding to the top and bottom of object & icon button labels. This fixes issues with labels being clipped on the bottom.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #6036 (91e52d7) into master (f98a2cd) will decrease coverage by 0.36%.
The diff coverage is n/a.

❗ Current head 91e52d7 differs from pull request most recent head e5e9d9f. Consider uploading reports for the commit e5e9d9f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6036      +/-   ##
==========================================
- Coverage   55.25%   54.89%   -0.36%     
==========================================
  Files         602      600       -2     
  Lines       24276    23599     -677     
  Branches     2147     2103      -44     
==========================================
- Hits        13413    12954     -459     
+ Misses      10257    10046     -211     
+ Partials      606      599       -7     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from 8cd6a50
e2e-full 51.23% <ø> (ø) Carriedforward from 8cd6a50
e2e-stable 50.06% <ø> (-2.31%) ⬇️
unit 50.38% <ø> (+0.23%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/operatorStatus/plugin.js 0.00% <0.00%> (-100.00%) ⬇️
...eratorStatus/pollQuestion/PollQuestionIndicator.js 0.00% <0.00%> (-100.00%) ⬇️
...orStatus/operatorStatus/OperatorStatusIndicator.js 0.00% <0.00%> (-100.00%) ⬇️
.../plugins/operatorStatus/AbstractStatusIndicator.js 0.00% <0.00%> (-93.75%) ⬇️
src/api/user/StatusAPI.js 40.25% <0.00%> (-44.16%) ⬇️
src/plugins/viewLargeAction/viewLargeAction.js 40.00% <0.00%> (-35.00%) ⬇️
src/plugins/linkAction/LinkAction.js 69.23% <0.00%> (-13.44%) ⬇️
example/exampleUser/ExampleUserProvider.js 55.55% <0.00%> (-13.20%) ⬇️
src/plugins/move/MoveAction.js 77.50% <0.00%> (-6.13%) ⬇️
src/api/indicators/SimpleIndicator.js 92.68% <0.00%> (-4.88%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98a2cd...e5e9d9f. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Dec 5, 2022
@ozyx ozyx changed the title style: added padding to object & icon button labels [CLA Pending] style: added padding to object & icon button labels Dec 5, 2022
@akhenry akhenry self-requested a review December 5, 2022 22:03
@ozyx ozyx added this to the Target:2.1.5 milestone Dec 6, 2022
@jvigliotta jvigliotta changed the title [CLA Pending] style: added padding to object & icon button labels [CLA on File] style: added padding to object & icon button labels Dec 6, 2022
@ozyx ozyx requested a review from charlesh88 December 8, 2022 21:29
@akhenry
Copy link
Contributor

akhenry commented Dec 19, 2022

@taintedbones Thanks for taking a look at this! The fix works @ 100% zoom, which is awesome. Problem is still occurring at other zoom levels though.

eg.

Chrome @ 100% ✅
Screen Shot 2022-12-19 at 10 27 29 AM

Chrome @ 110% ❌
Screen Shot 2022-12-19 at 10 27 48 AM

@taintedbones
Copy link
Contributor Author

@akhenry Thank you for the feedback! So I went back to check on this and couldn't replicate the issue on my branch. However, when I swapped over to master branch, the issue existed there.

Chrome 100%
openmct100

Chrome 110%
openmct110

@akhenry
Copy link
Contributor

akhenry commented Jan 9, 2023

@taintedbones OK, let me take another look! Thanks.

@akhenry
Copy link
Contributor

akhenry commented Jan 18, 2023

Have retested and this looks good to me. Sorry, I don't know what I did last time :)

@charlesh88 This look good to you?

Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this branch is changing plot images in the e2e tests folder... CSS changes look good, and this is good to go once we clarify what's going on with e2e images.

@ozyx
Copy link
Contributor

ozyx commented Jan 19, 2023

Not sure why this branch is changing plot images in the e2e tests folder... CSS changes look good, and this is good to go once we clarify what's going on with e2e images.

@charlesh88:
These changes were from me. Needed to update our e2e snapshots due to visual change on the main view. The object name in the main view above the plot got a 1px padding so it squashed the plot by 1 pixel, causing the snapshot tests to fail. Any issues you foresee with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon button labels are being clipped
5 participants