Description
Description
The cFS application template was originally built for ICAROUS, but it is now generic to cFS. ICAROUS is still mentioned in the template, and the resulting code will not compile unless ICAROUS is present as an app.
Type
- Bug: cFS template generates code that does not work in cFS, but requires a specific cFS application to be present.
Additional context
None.
Requester
- Ivan Perez.
Method to check presence of bug
Searching for ICAROUS in the template surfaces several occurrences:
$ grep -niHre 'icarous' ogma-core/templates/
ogma-core/templates/copilot-cfs/fsw/src/copilot_cfs.h:44:void COPILOT_ProcessIcarousPosition(void);
ogma-core/templates/copilot-cfs/fsw/src/copilot_cfs.c:19:#include "Icarous_msgids.h"
ogma-core/templates/copilot-cfs/fsw/src/copilot_cfs.c:20:#include "Icarous_msg.h"
ogma-core/templates/copilot-cfs/fsw/src/copilot_cfs.c:154:* Make ICAROUS data available to Copilot and run monitors.
ogma-core/templates/copilot-cfs/CMakeLists.txt:5:include_directories(../Icarouslib/fsw/platform_inc)Expected result
Running the command above returns an empty output, showing that ICAROUS is not mentioned in the template.
Desired result
Running the command above returns an empty output, showing that ICAROUS is not mentioned in the template.
Proposed solution
Modify copilot_cfs.h header to make use of existing template variables.
Modify copilot_cfs.c to replace the specific includes with a new variable that is expanded in place.
Modify copilot_cfs.c to remove ICAROUS from the comment documenting the message handler function.
Modify CMakeLists.txt to replace the specific include of Icarouslib with an additional variable that is expanded in place.
Document new variables in ogma-cli's README.
Further notes
None.