Refactor #59
Merged
Refactor #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nametake
commented
Apr 20, 2025
nametake
commented
- change interface{} to any
- update go.mod
- fix log
- add monorepo test
Add Error field to GolangCILintResult struct for better error handling. Improve logging by: - Adding Debugf method to logger interface - Adding early return after logging JSON marshal errors - Replacing DebugJSON with Debugf for improved command visibility - Standardizing printf formatting with explicit newlines
Replace interface{} with the any type alias throughout the codebase,
as recommended since Go 1.18. Also improve logging by replacing
the Debugf method with more structured DebugJSON calls and removing
redundant newlines in format strings.
Replace direct os.Stderr usage with log.Writer() to maintain consistency with Go's standard logging patterns. Add log.LstdFlags to include timestamps in log output, which improves log readability and debugging.
Remove the obsolete "nolint:gosec" comment from the exec.Command call, as this code has either been reviewed for security concerns or the potential issues have been addressed through other means.
Remove unnecessary nolint directives that were previously used to suppress linter warnings for unused code and magic numbers. These annotations are no longer needed as the code has been properly refactored. Also renamed an unused parameter in handlerWorkspaceDidChange Configuration to underscore to indicate it's intentionally unused.
Update the sourcegraph/jsonrpc2 dependency from a development version to the stable v0.2.0 release. This improves code maintainability by using a versioned dependency rather than a commit hash reference.
Add integration tests for the linter in a monorepo structure with foo and bar modules that have different linter configurations: - foo module has wsl enabled but unused disabled - bar module has both wsl and unused enabled - Added test fixtures with appropriate .golangci.yaml configs
Enhance test case names to clearly indicate testing of monorepo setup with multiple go.mod and golangci-yaml files, identifying both foo and bar module test cases separately for better clarity and documentation.
Update the Go module version requirement to use the latest stable version of Go. This ensures compatibility with current tooling and access to recent language improvements and bug fixes.
Change the Go module version requirement from 1.24.2 to 1.23.4 to ensure better compatibility with existing environments and toolchains that might not support the newer Go version yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.