Avoid returning negative positions #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the LSP spec, the line and character must both be unsigned integers. The spec also specifically calls out that `-1` is not supported: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position With some code structures, it is possible to produce an error such as the following from `golangci-lint run --out-format=json`: ```json { "FromLinter": "typecheck", "Text": ": # github.com/my/package [github.com/my/package.test]\n./main.go:31:2: undefined: asdf", "Severity": "", "SourceLines": [ "package main" ], "Replacement": null, "Pos": { "Filename": "main.go", "Offset": 0, "Line": 1, "Column": 0 }, "ExpectNoLint": false, "ExpectedNoLintLinter": "" } ``` This ultimately does result in some issues with tooling compatibility, for example: folke/trouble.nvim#224 (comment) By preventing the number from dropping below zero, this class of error should no longer be present.
|
@nametake let me know if there's anything I can do to help get this merged |
nametake
approved these changes
Dec 16, 2023
|
Thank you! |
kirillrdy
reviewed
Jan 5, 2024
| @@ -104,6 +110,13 @@ func (h *langHandler) lint(uri DocumentURI) ([]Diagnostic, error) { | |||
| return diagnostics, nil | |||
| } | |||
|
|
|||
| func max(a, b int) int { | |||
There was a problem hiding this comment.
go 1.21 has max/min builtin, sadly golang allows shadowing of builtins.
can we bump golang go 1.21 and use builtin ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the LSP spec, the line and character must both be unsigned integers. The spec also specifically calls out that
-1is not supported: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#positionWith some code structures, it is possible to produce an error such as the following from
golangci-lint run --out-format=json:{ "FromLinter": "typecheck", "Text": ": # github.com/my/package [github.com/my/package.test]\n./main.go:31:2: undefined: asdf", "Severity": "", "SourceLines": [ "package main" ], "Replacement": null, "Pos": { "Filename": "main.go", "Offset": 0, "Line": 1, "Column": 0 }, "ExpectNoLint": false, "ExpectedNoLintLinter": "" }This ultimately does result in some issues with tooling compatibility, for example: folke/trouble.nvim#224 (comment)
By preventing the number from dropping below zero, this class of error should no longer be present.