Fix nested key deletion #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #33. Adds a clause for the `jsn__delete` value to short-circuit the automatic path creation used in the value-setting path. For backward compatibility, I implemented an internal `return_if_object/2` function to preserve throwing `not_an_object` errors that happen when you try to delete binary keys from arrays, etc.
jadeallenx
approved these changes
Feb 8, 2020
|
|
nalundgaard
added a commit
that referenced
this pull request
Feb 9, 2020
* Fix nested key deletion (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33.
Adds a clause for the
jsn__deletevalue to short-circuit the automatic path creation used in the value-setting path. For backward compatibility, I implemented an internalreturn_if_object/2function to preserve throwingnot_an_objecterrors that happen when you try to delete binary keys from arrays, etc.