Skip to content

Add Slack Trigger node #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2024
Merged

Add Slack Trigger node #2057

merged 3 commits into from
May 22, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Apr 23, 2024

@Joffcom Joffcom added the pending-dev Blocked pending merge of related dev PR label Apr 23, 2024
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit 8c75b85
🔍 Latest deploy log https://app.netlify.com/sites/n8n-docs/deploys/662a1c06e984400008abb0a9
😎 Deploy Preview https://deploy-preview-2057--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 23, 2024

Overall readability score: 45.26 (🟢 +0.01)

File Readability
slack.md 80.65 (🟢 +0)
n8n-nodes-base.slacktrigger.md 51.7 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
slack.md 80.65 67.35 6.49 8.8 10.02 5.95
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
n8n-nodes-base.slacktrigger.md 51.7 55.88 12.85 14.3 10.68 8.2
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 45.26 39 11.9 14.37 13.53 8.56
  🟢 +0.01 🟢 +0.02 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@Joffcom Joffcom marked this pull request as ready for review April 25, 2024 08:27
@StarfallProjects StarfallProjects self-requested a review April 25, 2024 08:58

## Slack configuration

To use this node you first need to create an application in Slack and enable event subscriptions. For the **Request URL** input the production or test URL displayed in the webhooks section of the node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention that they should install the App in a Slack workspace and that it should be channel member for some events? Maybe it's obvious but I forgot while testing 🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good idea I will add that shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joffcom do you still need to do this? Or is this PR ready to merge?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New plan: I want to link this from the release note. So merging - can always add more detail later if you still need to.

@StarfallProjects StarfallProjects added in-next-release Follow-up to pending-dev. Use once the linked dev PR is merged. and removed pending-dev Blocked pending merge of related dev PR in-next-release Follow-up to pending-dev. Use once the linked dev PR is merged. labels May 22, 2024
@StarfallProjects StarfallProjects merged commit 639e04b into main May 22, 2024
@StarfallProjects StarfallProjects deleted the slack-trigger-node branch May 22, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants