fix(iroh): better waiting for the NodeAddr to be ready in the echo example #3424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a major footgun right now, and even this basic example gets it wrong.
Breaking Changes
Notes & open questions
There might be other examples affected, I didn't look.
My first version was very different, and absolutely horrible to write and still failed because of obscure borrowing errors. This is probably rather difficult for people new to rust. Maybe we need to provide a better helper function?
Change checklist