-
Notifications
You must be signed in to change notification settings - Fork 288
chore: switch from backoff
to backon
#3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3227/docs/iroh/ Last updated: 2025-03-13T17:43:25Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. backon
even has a better API than backoff
IMO.
Also this makes me consider moving the retry logic into the iroh_relay::ClientBuilder
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodness, why do we have these unmaintained advisories? Unmaintained crates are great! They don't update all the time. Why can't we have finished software?
Description
backoff
is no longer maintained, upgrade path in cargo-deny indicates switching tobackon
.Notes & open questions
There are some options in
backon
for using sleepers in the retry that are Wasm compatible: https://docs.rs/backon/1.4.0/backon/#sleepI'm curious if we should be taking advantage.
Further questions:
how do I resolve thepaste
cargo-deny issue?I don't: added
paste
andhumantime
advisories to the "allow" listChange checklist