Skip to content

chore: switch from backoff to backon #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 13, 2025
Merged

chore: switch from backoff to backon #3227

merged 7 commits into from
Mar 13, 2025

Conversation

ramfox
Copy link
Member

@ramfox ramfox commented Mar 12, 2025

Description

backoff is no longer maintained, upgrade path in cargo-deny indicates switching to backon.

Notes & open questions

There are some options in backon for using sleepers in the retry that are Wasm compatible: https://docs.rs/backon/1.4.0/backon/#sleep

I'm curious if we should be taking advantage.

Further questions:
how do I resolve the paste cargo-deny issue?
I don't: added paste and humantime advisories to the "allow" list

Change checklist

  • Self-review.

@ramfox ramfox requested a review from flub March 12, 2025 19:58
Copy link

github-actions bot commented Mar 12, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3227/docs/iroh/

Last updated: 2025-03-13T17:43:25Z

Copy link

github-actions bot commented Mar 12, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 54f1e4f

@n0bot n0bot bot added this to iroh Mar 12, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Mar 12, 2025
Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. backon even has a better API than backoff IMO.

Also this makes me consider moving the retry logic into the iroh_relay::ClientBuilder.

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodness, why do we have these unmaintained advisories? Unmaintained crates are great! They don't update all the time. Why can't we have finished software?

@ramfox ramfox added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 14795ab Mar 13, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Mar 13, 2025
@ramfox ramfox deleted the backon branch March 14, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants