-
Notifications
You must be signed in to change notification settings - Fork 236
fix(relay)!: change default cert format from der to pem #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3204/docs/iroh/ Last updated: 2025-03-05T10:32:34Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why does reloading need to choose the cert format while manual does not? Why can't they both use the same format and be done because no one seems to have asked for the other format? And if it does need to be configurable, why only for one of them?
- The
cfg
is rather suspicious. All of main.rs is server-only surely. Surely we can figure out a way to make this work correctly without having to cfg-spaghetti the code.
I guess I just went with providing both since the original was not satisfactory. Moved everything to PEM by default. If the need arises I'll bring back DER and add it to both manual and reloading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that's a simple PR :)
Please note you need to list this as breaking changes. And need to add the |
Description
PEM format is probably the more used option for this use case so switching around defaults.
Also addingcert_format
so you can specifyDER
as an alternative.Breaking Changes
Changes the default cert format for
Reloading
certificate mode fromDER
toPEM
Notes & open questions
Change checklist
quic-rpc
iroh-gossip
iroh-blobs
dumbpipe
sendme