Skip to content

fix(relay)!: change default cert format from der to pem #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Feb 25, 2025

Description

PEM format is probably the more used option for this use case so switching around defaults. Also adding cert_format so you can specify DER as an alternative.

Breaking Changes

Changes the default cert format for Reloading certificate mode from DER to PEM

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Arqu Arqu changed the title fix: change default cert format from der to pem fix(relay): change default cert format from der to pem Feb 25, 2025
@Arqu Arqu requested review from flub and dignifiedquire February 25, 2025 22:03
@Arqu Arqu self-assigned this Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3204/docs/iroh/

Last updated: 2025-03-05T10:32:34Z

Copy link

github-actions bot commented Feb 25, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 50cd09b

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why does reloading need to choose the cert format while manual does not? Why can't they both use the same format and be done because no one seems to have asked for the other format? And if it does need to be configurable, why only for one of them?
  • The cfg is rather suspicious. All of main.rs is server-only surely. Surely we can figure out a way to make this work correctly without having to cfg-spaghetti the code.

@Arqu
Copy link
Collaborator Author

Arqu commented Mar 5, 2025

  • Why does reloading need to choose the cert format while manual does not? Why can't they both use the same format and be done because no one seems to have asked for the other format? And if it does need to be configurable, why only for one of them?

    • The cfg is rather suspicious. All of main.rs is server-only surely. Surely we can figure out a way to make this work correctly without having to cfg-spaghetti the code.

I guess I just went with providing both since the original was not satisfactory. Moved everything to PEM by default. If the need arises I'll bring back DER and add it to both manual and reloading.

@Arqu Arqu requested a review from flub March 5, 2025 10:32
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's a simple PR :)

@flub
Copy link
Contributor

flub commented Mar 5, 2025

Please note you need to list this as breaking changes. And need to add the ! to the title.

@Arqu Arqu changed the title fix(relay): change default cert format from der to pem fix(relay)!: change default cert format from der to pem Mar 5, 2025
@Arqu Arqu added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 4930837 Mar 5, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in iroh Mar 5, 2025
@Arqu Arqu deleted the arqu/derpem branch March 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants