refactor(iroh): remove genawaiter usage from dht discovery #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3048/docs/iroh/ Last updated: 2024-12-16T09:57:10Z |
matheus23
reviewed
Dec 16, 2024
rklaehn
reviewed
Dec 16, 2024
| let pkarr_public_key = | ||
| pkarr::PublicKey::try_from(node_id.as_bytes()).expect("valid public key"); | ||
| tracing::info!("resolving {} as {}", node_id, pkarr_public_key.to_z32()); | ||
| Some(Gen::new(|co| async move { this.gen_resolve(node_id, co).await }).boxed()) | ||
|
|
||
| let mut stream = futures_buffered::FuturesUnorderedBounded::new(2); |
There was a problem hiding this comment.
We are not really removing genawaiter but replacing genawaiter with futures_buffered. But since we need that anyway in a bunch of places, makes sense.
Even though I really like genawaiter...
dignifiedquire
force-pushed
the
refactor-remove-genawaiter
branch
from
32756a3 to
4956e00
Compare
matheus23
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One less dependency in the core of iroh
Breaking Changes
Notes & open questions
Change checklist